WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] ns16550 polling timeout sanity check

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] ns16550 polling timeout sanity check
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Thu, 01 Dec 2005 09:59:13 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 01 Dec 2005 16:57:21 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: LOSL
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Keir,

   Here's a small sanity check fix for the recently added ns16550
polling support.  If a device has a 1 byte tx fifo it's not hard for the
integer math to end up with a 0 timeout.  Default to a 1ms timeout if
this happens.  Thanks,

        Alex

Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>
---

diff -r f5b119533cc8 xen/drivers/char/ns16550.c
--- a/xen/drivers/char/ns16550.c        Thu Dec  1 14:22:22 2005
+++ b/xen/drivers/char/ns16550.c        Thu Dec  1 09:28:48 2005
@@ -212,6 +212,8 @@
         /* Polled mode. Calculate time to fill RX FIFO and/or empty TX FIFO. */
         bits = uart->data_bits + uart->stop_bits + !!uart->parity;
         uart->timeout_ms = (bits * port->tx_fifo_size * 1000) / uart->baud;
+        if (!uart->timeout_ms)
+            uart->timeout_ms = 1;
         init_ac_timer(&uart->timer, ns16550_poll, port, 0);
         set_ac_timer(&uart->timer, NOW() + MILLISECS(uart->timeout_ms));
     }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>