WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Problem with setmaxmem()

To: Amitayu Das <amitayudas@xxxxxxxxx>
Subject: Re: [Xen-devel] Problem with setmaxmem()
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Sun, 27 Nov 2005 01:24:53 +0000
Cc: Xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 27 Nov 2005 01:24:44 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <5f74ce410511261710v303d75c8j88658cf2a913a06d@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <5f74ce410511261710v303d75c8j88658cf2a913a06d@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Sat, Nov 26, 2005 at 08:10:26PM -0500, Amitayu Das wrote:

> [Snip]
> static PyObject *pyxc_domain_setmaxmem(XcObject *self, PyObject *args) [**
> note that no keywords in the list of parameters]
> 
> although,  /usr/lib/python/xen/xend/XendDomain.py is using this function
> as
> 
>         try:
>             return xc.domain_setmaxmem(dominfo.getDomid(),
>                                        maxmem_kb = maxmem) [** note that
> keywords are being sent as arguments]
> 
> Since, the things are not matching, is this a bug or am I missing
> something. Please help........

That's a bug.  Thanks for your report.  You can just remove the maxmem_kb =
here and anywhere else that this problem occurs (I recently tidied up the
argument handling, and obviously have broken this call).

Please note, however, that xm mem-max is dangerous, and using it to shrink the
domain will probably crash it.  You want to try xm mem-set, which sets a soft
limit instead, and will shrink the domain without crashing it.  There is a 
bug outstanding (#212) to remove the xm mem-set command (or at the very least
to reduce its potency).  Please don't use it, and use xm mem-set instead.

Ewan. 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>