 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] add polling support for ns16550
| To: | Alex Williamson <alex.williamson@xxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] add polling support for ns16550 |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Thu, 24 Nov 2005 11:13:40 +0000 |
| Cc: | Xen Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Thu, 24 Nov 2005 11:08:09 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <1132764049.18843.7.camel@tdi> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <1132764049.18843.7.camel@tdi> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 23 Nov 2005, at 16:40, Alex Williamson wrote: The patch below adds ac_timer based polling to the ns16550 UART driver. This is useful when the interrupt line is not connected in hardware or the mechanism to enable it is not readily available in the hypervisor. Polling is only enabled when the UART IRQ is set to zero. Thanks, I reworked the patch a little and checked it in, thanks.One thing I removed was the clear-and-reset of IER in the timeout handler. Given we write zero to IER in the preirq steup function, and also we do not set the master-enable bit in the MCR, I cannot see how you could end up accidentally fielding interrupts in the timeout handler. Did I miss something? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Problem with vif - help!!!!, Ewan Mellor |
|---|---|
| Next by Date: | [Xen-devel] [patch] CFQ for xen domains, Gerd Knorr |
| Previous by Thread: | [Xen-devel] [PATCH] add polling support for ns16550, Alex Williamson |
| Next by Thread: | Re: [Xen-devel] [PATCH] add polling support for ns16550, Alex Williamson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
