WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] Fix stack dump on improper use of domid and domname

To: Xen Developers <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Fix stack dump on improper use of domid and domname
From: Dan Smith <danms@xxxxxxxxxx>
Date: Thu, 03 Nov 2005 14:52:22 -0800
Delivery-date: Thu, 03 Nov 2005 22:52:39 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.4 (gnu/linux)
This is another patch that adds an arg_check() to domid and domname so
that we don't dump stack if a user runs either without an argument.

Signed-off-by: Dan Smith <danms@xxxxxxxxxx>
diff -r 289b73a5ace7 tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py       Thu Nov  3 08:58:45 2005
+++ b/tools/python/xen/xm/main.py       Thu Nov  3 14:36:31 2005
@@ -464,6 +464,8 @@
     server.xend_domain_set_vcpus(args[0], int(args[1]))
 
 def xm_domid(args):
+    arg_check(args, 1, "domid")
+
     name = args[0]
 
     from xen.xend.XendClient import server
@@ -471,6 +473,8 @@
     print sxp.child_value(dom, 'domid')
     
 def xm_domname(args):
+    arg_check(args, 1, "domname")
+
     name = args[0]
 
     from xen.xend.XendClient import server
-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@xxxxxxxxxx
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Fix stack dump on improper use of domid and domname, Dan Smith <=