WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel][PATCH][VT] Multithread IDE device model ( was: RE: [Xen-

To: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Subject: Re: [Xen-devel][PATCH][VT] Multithread IDE device model ( was: RE: [Xen-devel] [PATCH]Make IDE dma tranfer run in another thread inqemu)
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Wed, 26 Oct 2005 17:05:31 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, "Yang, Xiaowei" <xiaowei.yang@xxxxxxxxx>
Delivery-date: Wed, 26 Oct 2005 22:02:47 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <37FBBA5F3A361C41AB7CE44558C3448E05884898@pdsmsx403>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <37FBBA5F3A361C41AB7CE44558C3448E05884898@pdsmsx403>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.7 (X11/20051013)
Dong, Eddie wrote:

Hi Anthony:
        I think you made misunderstanding to this patch. Current Qemu in
Xen is already DMA enabled. If I remembered correctly, it happens since
we change DM from Bochs to Qemu.
        Without this patch, guest IO operation that trigger DMA (like
port 0xc000 write) will wait in Qemu till the DMA operation is
completed, that is original single thread IDE device model mean. With this patch, a seperate thread will service the dma
operation started by IO operation, and interrupt target processor when
it is completed, while the main thread can rapidly return to guest (like
0xc000 write).
Yup, the site I linked to has two patches: a DMA patch and a concurrent IO patch.

Here's a direct link: http://people.brandeis.edu/~jcoiner/qemu_idedma/qemu_concurrent_io.patch

It's using the same basic approach as your patch (another thread waits for completion of IO event). I'm pointing it out though in case there's a desire to stay closer to QEMU upstream when possible. Might enable more code sharing in the future.

Regards,

Anthony Liguori

Thanks,eddie

Anthony Liguori wrote:
Hi Eddie,

There was a patch floating around on qemu-devel recently to make IDE
DMA concurrent.  Fabrice is planning to include it in QEMU as long as
there are no regressions.  It may already be in CVS.

See
http://people.brandeis.edu/~jcoiner/qemu_idedma/qemu_dma_patch.html
The reported performance improvement IO is up to 20% so it's
definitely worth applying...

Regards,

Anthony Liguori




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel