WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH][RESEND] Control panel changes for IA64/VTI

To: "Ewan Mellor" <ewan@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH][RESEND] Control panel changes for IA64/VTI
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Mon, 24 Oct 2005 18:55:21 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Xen-IA64-Devel <Xen-IA64-Devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 24 Oct 2005 10:52:44 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcXYgrFRnOdmsj6RRRyRi/mYE6txbgABbIhQ
Thread-topic: [Xen-devel] [PATCH][RESEND] Control panel changes for IA64/VTI
Ewan, thanks for pointing out following obvious error, and I need to make patch 
more carefully next time. ;-)

Attached the updated version. To reduce the mail size, I skipped attaching the 
other untouched one.

Thanks,
Kevin

>From: Ewan Mellor [mailto:ewan@xxxxxxxxxxxxx]
>Sent: 2005年10月24日 18:07
>On Mon, Oct 24, 2005 at 09:19:33AM +0800, Tian, Kevin wrote:
>
>> >From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>> >
>> >The patches look okay, although the Python bits aren't particularly
>> >pretty.
>> >
>> >  -- Keir
>>
>> Sorry for bad Python skill. ;-) So Dan, please help check in.
>
>Actually executing your code would be a good start.
>
>--- a/tools/python/xen/xend/image.py   Sat Oct 15 03:09:43 2005
>+++ b/tools/python/xen/xend/image.py   Fri Oct 21 15:35:26 2005
>@@ -58,6 +58,7 @@
>     """
>
>     ostype = None
>+    page_kb = 4
>
>
>     def __init__(self, vm, imageConfig, deviceConfig):
>@@ -366,11 +367,13 @@
>
>     def getDomainMemory(self, mem):
>         """@see ImageHandler.getDomainMemory"""
>+      if os.uname[4] == 'ia64':
>+          page_kb = 16
>         # for ioreq_t and xenstore
>         static_pages = 2
>
>This is going to fail with a TypeError exception, because os.uname is a
>function.  You want os.uname()[4].
>
>Ewan.

Attachment: patch_vti_cp_common
Description: patch_vti_cp_common

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel