Re: [Xen-devel] block-nbd script and example config

[Anthony Liguori <aliguori@xxxxxxxxxx>]

Ian Pratt wrote:

> disk = [ 'nbd:134.100.233.115 20004,hda1,w' ]
>
> I think having the space in the export device name is just a little too
> nauseating :-)
>
> Could we make the script take ip:port and then turn the ':' into a space
> when invoking nbdclient?
>
> On this subject, I think it would be less confusing if we configured
> disks using a syntax more akin to that which we use for networking e.g.:
>  
I actually like this idea a lot.  I'm not a huge fan of the current 
block device configuration.
> disks = [ 'export=phy:/dev/sda1, target=/dev/sda1, options=rw',
>          'export=phy:/dev/vg/my_usr, target=/dev/sdb1, options=ro' ]
>
> I know its late in the day to be making changes like this, but it
> doesn't hurt to canvass opinion...
>  
The only thing to think about is how do handle file devices with spaces 
in the filename.  This is going to be common I think.
Comma and spaces are valid filename characters.  I think : is probably 
the safest separator since it's used a lot.
> I'd also do away with all the fancy stuff we have to build the command
> line and just have a single command line variable that we assemble
> everything in to within the config file. The current magic just makes
> things more confusing.
>  
Yes :-)

Regards,

Anthony Liguori

> Ian
>
>
>
>
>
> Ian
>  
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>
>  
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel