WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Switching from writeable pagetabletoshadowlog-dirtyat ru

To: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>, "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx>, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] Switching from writeable pagetabletoshadowlog-dirtyat runtime
From: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Date: Fri, 14 Oct 2005 22:44:50 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sat, 15 Oct 2005 05:42:22 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcXQm9MMZoDuCgMpRheI6PFoTqkVkwAB1n+AACDaXcAACRKHsA==
Thread-topic: [Xen-devel] Switching from writeable pagetabletoshadowlog-dirtyat runtime
Ian Pratt wrote:
>> We found that in 32-bit code, the shadow_fault() do one more thing
>> than 64-bit code. The following code in file shadow32.c checks the
>> L1 page table with RW bit removed and make the shadow with RW bit, it
>> does not inject the fault to guest.
>> Does this is a work-around for switch from writable pagetable to
>> shadow mode enable? Does this code makes sense to the writeable
>> pagetable, and then may be one reason that 32bit log-dirty code can
>> work? 
> 
> Yep, the code you highlight is in shadow32 to support writable
> pagetable emulation when in shadow mode.
> 
> My original shadow mode implementation didn't need special case code
> to handle writable pagetables as the shadow fault handler was called
> after the writeable pagetable handler in the main page fault handler:
> the writeable pagetable fault was handled but then eecution was
> allowed to drop through into the shadow fault handler, propagating
> the change into the shadow pagetable without having to take another
> fault. It may be possible to do something similar to remove the
> special case, but I'm less familiar with the current code.
> 
> Ian

So, let's add the code to shadow.c and continue on debugging. 

Jun
---
Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>