This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] suggested event channel cleanups

To: "King, Steven R" <steven.r.king@xxxxxxxxx>
Subject: Re: [Xen-devel] suggested event channel cleanups
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 11 Oct 2005 10:18:08 +0100
Cc: xen-devel List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 11 Oct 2005 09:10:30 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <44BDAFB888F59F408FAE3CC35AB47041022BD367@orsmsx409>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <44BDAFB888F59F408FAE3CC35AB47041022BD367@orsmsx409>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 10 Oct 2005, at 23:50, King, Steven R wrote:

This patch standardizes the type of "port" to "int" for event channel
functions and structures. Internally, Xen is using "int" for ports, but
userland code has a mix of "int" and "u32".  Type "int" is preferred in
userland, since some functions want to return a positive port value or a
negative error code.

Userspace may do this, but Xen doesn't. It makes sense to give those fields an unsigned type because Xen will never return a negative value. If higher-level interfaces outside Xen return a signed type, with -ve indicating error, there's no reason for Xen to do the same.

xenctrl.h: Added extern "C" to allow linking with C++ programs.

Isn't it quite normal to put the ''extern "C"' in the C++ program itself when including C header files?

xenctrl.h: Added function prototype for event channel close.
xenctrl.h: Added function prototype for interdomain event channel.

These were removed last week.; The correct interface for user-space programs is now ioctls via /dev/xen/evtchn. See examples of its use in console/daemon/io.c, for example.

I've never offered up a patch before, so apologies if I'm abusing

There's nothing wrong with the format of the patch. :-)

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>