WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/

Home

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] Cleanup use of strlen() to check for empty strin

from [Keir Fraser]

[Permanent Link][Original]

To:	Jacob Gorm Hansen <jacobg@xxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] Cleanup use of strlen() to check for empty string
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Wed, 5 Oct 2005 11:35:07 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Wed, 05 Oct 2005 10:27:40 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<e08041f30510041550o26f63c32oded91ffedcb488e2@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<e08041f30510041550o26f63c32oded91ffedcb488e2@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 4 Oct 2005, at 23:50, Jacob Gorm Hansen wrote:

I came across checks for strlen(s)==0 a few places in drivers/xen.
Here is a patch to fix that.

Isn't your patch exactly equivalent? None of that code is time criticalenough that a call to strlen matters.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] Cleanup use of strlen() to check for empty string, Jacob Gorm Hansen Re: [Xen-devel] [PATCH] Cleanup use of strlen() to check for empty string, Keir Fraser <= Re: [Xen-devel] [PATCH] Cleanup use of strlen() to check for empty string, Jacob Gorm Hansen

Previous by Date:	Re: [Xen-devel] [PATCH] Makefile cleanup, Keir Fraser
Next by Date:	Re: [Xen-devel] Custom Guest OS not booting, Keir Fraser
Previous by Thread:	[Xen-devel] [PATCH] Cleanup use of strlen() to check for empty string, Jacob Gorm Hansen
Next by Thread:	Re: [Xen-devel] [PATCH] Cleanup use of strlen() to check for empty string, Jacob Gorm Hansen
Indexes:	[Date] [Thread] [Top] [All Lists]

This site is hosted by Citrix