Re: [Xen-devel] [PATCH] Fix tools makefile to properly check for external tools

[Jerone Young <jyoung5@xxxxxxxxxx>]

Ok ,thinking about the comment in tools/check/Makefile is so that one
could install stuff in "dist" directory. But our networking scripts have
no checks at all to see if (for example) "brctl" is even there...it just
silently installs. So given this when would one check that we have
everything need installed. Also I will submit a patch to add a check to
the network script to see if the tools are actually on the system.

On Tue, 2005-10-04 at 13:46 -0500, Jerone Young wrote:
> Signed-off-by: Jerone Young <jyoung5@xxxxxxxxxx>
> 
> Fix tools makefile so that extrnal tools checks are run to ensure
> extrnal tools  are actually installed.
> 
> diff -r 00037ba13f0b -r cc75d51355cb tools/Makefile
> --- a/tools/Makefile    Tue Oct  4 17:23:58 2005
> +++ b/tools/Makefile    Tue Oct  4 16:28:18 2005
> @@ -33,7 +33,7 @@
>         done
>         $(MAKE) ioemu
> 
> -install: check
> +install: check_install
>         @set -e; for subdir in $(SUBDIRS); do \
>                 $(MAKE) -C $$subdir $@; \
>         done
> @@ -48,6 +48,9 @@
>  check:
>         $(MAKE) -C check
> 
> +check_install:
> +       $(MAKE) -C check install
> +
>  check_clean:
>         $(MAKE) -C check clean
> 
> 
-- 
Jerone Young
IBM Linux Technology Center
jyoung5@xxxxxxxxxx
512-838-1157 (T/L: 678-1157)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel