WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Bug in the bind_evtchn_to_xxx patch

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Bug in the bind_evtchn_to_xxx patch
From: NAHieu <nahieu@xxxxxxxxx>
Date: Fri, 30 Sep 2005 16:23:14 +0900
Delivery-date: Fri, 30 Sep 2005 07:20:52 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=Yv/aInGc0BHv56mXlqijILbleNolC9nn93LsXxD/Vbr8f/196yrDQrdLwPADK1L8v3lr/ECbqVlu/PYHa4yrdiwgs8maX4c2UuUZQTQoPCpX4R621ZXMqiRUJFPf4GDD091F/FFRVEv/67dV9FIoBJNH/VSXW1RkybZ4DlVnbNA=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Reply-to: NAHieu <nahieu@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Keir, looks like in the below patch you had some typos - see lines
with (###): all the "tpm"  should be "tp".

Hieu.

----
# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID 559ad1abb3d502079ff5bbd39e2979f0a637549e
# Parent  805ee053e61f4c25e642ff3bb9e657966a15bc33
Change semantics of bind_evtchn_to_xxx and
unbind_evtchn_from_xxx. The bind now returns the IRQ
number on success. The unbind takes this as a parameter
instead of the event-channel port. Also, unbind closes
down the underlying event-channel port if it is still
live.
<snip>
--- a/linux-2.6-xen-sparse/drivers/xen/tpmfront/tpmfront.c      Thu
Sep 29 12:05:43 2005
+++ b/linux-2.6-xen-sparse/drivers/xen/tpmfront/tpmfront.c      Thu
Sep 29 14:14:03 2005
@@ -292,8 +292,10 @@
               free_page((unsigned long)tp->tx);
               tp->tx = NULL;
       }
-       unbind_evtchn_from_irqhandler(tp->evtchn, NULL);
-       tp->evtchn = 0;
+
+       if (tpm->irq)  (###)
+               unbind_evtchn_from_irqhandler(tp->irq, NULL);
+       tp->evtchn = tpm->irq = 0;   (###)
 }
<snip>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] Bug in the bind_evtchn_to_xxx patch, NAHieu <=