Re: [Xen-devel] xenbus_mkdir("/tools", "name") fails

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 28 Sep 2005, at 14:07, Anton Korenyushkin wrote:

> I have attached module's code. There are a lot of proc fs stuff in it,
> xenbus_mkdir is called when root writes something into 
> /proc/xen/prmigr. I
> execute commands xend start && echo 'hi' >/proc/xen/prmigr. And then i 
> get
> reboot.
Most obvious problem I can see is that the entire access isn;t 
protected by xenbus_lock. Given the current interface you would need to 
manually acquire and release the lock around your mkdir call. Actually 
I think that is pretty gross for singleton accesses like this. I'll 
change the interface to internally do the locking it requires -- 
exposing xenbus_lock outside xenbus is not really on. Especially since 
we hope to improve the locking strategy in future!
I'll check somethign appropriate in and let you know to give your 
driver another spin.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel