 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] [PATCH] Make 'xm restore' sanity check the path
| To: | Xen Developers <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] [PATCH] Make 'xm restore' sanity check the path |
| From: | Dan Smith <danms@xxxxxxxxxx> |
| Date: | Mon, 26 Sep 2005 10:44:55 -0700 |
| Delivery-date: | Mon, 26 Sep 2005 17:42:54 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) |
This patch adds a quick check to 'xm restore' that checks the existence and readability of the file given. This fixes the issue detected in xm-tests 03_restore_badparm_neg and 04_restore_badfilename_neg. Signed-off-by: Dan Smith <danms@xxxxxxxxxx> diff -r 5ea81e640509 tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py Sun Sep 25 10:47:22 2005
+++ b/tools/python/xen/xm/main.py Mon Sep 26 10:37:34 2005
@@ -183,6 +187,10 @@
arg_check(args,1,"restore")
savefile = os.path.abspath(args[0])
+
+ if not os.access(savefile, os.R_OK):
+ err("xm restore: Unable to read file %s" % savefile)
+ sys.exit(1)
from xen.xend.XendClient import server
info = server.xend_domain_restore(savefile)
-- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@xxxxxxxxxx _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] RE: Please pull xen-ia64-unstable, Magenheimer, Dan (HP Labs Fort Collins) |
|---|---|
| Next by Date: | Re: [Xen-devel] /proc/xen/xenbus supports watch?, Christian Limpach |
| Previous by Thread: | CONTACT YOUR PAYING BANK, South Australia lotteries |
| Next by Thread: | Re: [Xen-devel] [PATCH] Make 'xm restore' sanity check the path, Ewan Mellor |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
