WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] Fix another race condition in xm destroy

To: Christian.Limpach@xxxxxxxxxxxx
Subject: [Xen-devel] Re: [PATCH] Fix another race condition in xm destroy
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Fri, 16 Sep 2005 16:35:18 -0500
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 16 Sep 2005 21:33:24 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <3d8eece20509161200674eff54@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <432A4D3A.6060300@xxxxxxxxxx> <3d8eece20509161200674eff54@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.6 (X11/20050912)
Christian Limpach wrote:

On 9/16/05, Anthony Liguori <aliguori@xxxxxxxxxx> wrote:
There's a race condition in xm destroy that gets triggered when
xc_domain_destroy results in a domain disappearing before we invoke the
cleanup routines.  Specifically, the saveToDB routines will through a No
such process error.

Christian, I'd appreciate if you could sanity check this before
committing.  I think it's okay because starting the cleanup shouldn't
have any adverse effects.  Having another pair of eyes confirm it would
make me feel better though :-)

How does it fail for you?  I fixed one issue where we were clearing
the store event channel and writing that back to the store was
failing.
You're fix solved the problem. That's why I made sure to ask, I wasn't confident my solution was correct :-)

Thanks,

Anthony Liguori

I'd prefer to keep doing the cleanup after destroy_domain.

    christian



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>