Re: [Xen-devel] [PATCH] workaround for bug#197: second try

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 13 Sep 2005, at 19:22, Ryan Harper wrote:

> If we are to believe the comment, (which makes sense), then the while 
> loop code
> is broken.  That is, this function will spin until *any* of the three 
> tests
> returns false rather than waiting until *all* tests are false. This 
> patch
> switches the &&s to ||s and inverts the domain_runnable() check.  I 
> believe we
> want to spin while 1) vcpu_running flag is up 2) the domain is 
> runnable and 3)
> the scheduler lock is held.
Good catch. Actually we want to spin only while the domain is 
non-runnable (just to catch the very unlikely event that someone else 
wakes the domain while we spin). I updated the comment and the loop 
predicate and checked the patch in. Thanks!
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel