WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] workaround for bug#197

To: "Ryan Harper" <ryanh@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] workaround for bug#197
From: "Puthiyaparambil, Aravindh" <aravindh.puthiyaparambil@xxxxxxxxxx>
Date: Mon, 12 Sep 2005 18:56:00 -0400
Cc: "Koren, Bradley J" <Bradley.Koren@xxxxxxxxxx>, "Subrahmanian, Raj" <raj.subrahmanian@xxxxxxxxxx>, "Vessey, Bruce A" <Bruce.Vessey@xxxxxxxxxx>
Delivery-date: Mon, 12 Sep 2005 22:53:54 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcW34QNyr4JHYps7RU+h5GfrTALysgAC3h4Q
Thread-topic: [Xen-devel] [PATCH] workaround for bug#197
Ryan,

After applying your patch, I tried out the scenario where I purposely
caused a kernel panic and then did an "xm destroy" on the domain.
(http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=223)

I see your printk but the system hangs after that.

(XEN) ACK! DOM1 still running, waiting before dying

Let me know if I can be of any help in debugging this.

Aravindh


> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:xen-devel-
> bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Ryan Harper
> Sent: Monday, September 12, 2005 5:28 PM
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-devel] [PATCH] workaround for bug#197
> 
> 
> I don't think this is the right fix, but it does highlight the issue.
> While killing a domain, the vcpus are descheduled, but every
> now and then, one of the cpus is still running one of the vcpus, which
> means d->cpumask is not empty.   This triggers the BUG_ON() in
> xen/arch/x86/domain.c:domain_relinquish_resources().  The patch puts
in
> some printks and a cpu_relax() loop till the cpumask is empty before
> calling domain_relinquish_resources().   With this patch, I've gone
> through several thousand iterations of create/destroy without
crashing.
> 
> --
> Ryan Harper
> Software Engineer; Linux Technology Center
> IBM Corp., Austin, Tx
> (512) 838-9253   T/L: 678-9253
> ryanh@xxxxxxxxxx
> 
> 
> diffstat output:
>  domain.c |    8 ++++++++
>  1 files changed, 8 insertions(+)
> 
> Signed-off-by: Ryan Harper <ryanh@xxxxxxxxxx>
> ---
> 
> diff -r 413c911e5780 xen/common/domain.c
> --- a/xen/common/domain.c     Mon Sep 12 12:48:33 2005
> +++ b/xen/common/domain.c     Mon Sep 12 13:25:07 2005
> @@ -112,6 +112,14 @@
>      {
>          for_each_vcpu(d, v)
>              sched_rem_domain(v);
> +        if(!cpus_empty(d->cpumask)) {
> +            printk("ACK! DOM%d still running, waiting before
dying\n",
> +                   d->domain_id);
> +            while(!cpus_empty(d->cpumask))
> +                cpu_relax();
> +            printk("DOM%d cpumask clear, relinquishing resources\n",
> +                   d->domain_id);
> +        }
>          domain_relinquish_resources(d);
>          put_domain(d);
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • RE: [Xen-devel] [PATCH] workaround for bug#197, Puthiyaparambil, Aravindh <=