WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Convert shutdown to use xenstore

To: aq <aquynh@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Convert shutdown to use xenstore
From: Dan Smith <danms@xxxxxxxxxx>
Date: Thu, 04 Aug 2005 21:06:56 -0700
Cc: "List: Xen Developers" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 05 Aug 2005 04:05:50 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <m364ulzpde.fsf@xxxxxxxxxxxxxxxxxxxxxxxx> <9cde8bff050804205857e191e4@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.4 (gnu/linux)
aq> How about putting declaration of err2 inside a "#ifdef
aq> CONFIG_MAGIC_SYSRQ" ?

Oh, I guess that'll issue a warning if CONFIG_MAGIC_SYSRQ isn't
enabled, won't it?

aq> Besides i think some printk should use KERN_ERR to report error
aq> properly.

OK.  I'll wrap these and the other suggestions in a new patch and
re-submit tomorrow.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@xxxxxxxxxx


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel