This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Convert balloon driver to xenstore

To: aq <aquynh@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Convert balloon driver to xenstore
From: Dan Smith <danms@xxxxxxxxxx>
Date: Wed, 03 Aug 2005 06:47:20 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 03 Aug 2005 13:46:14 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <m38xzllglg.fsf@xxxxxxxxxxxxxxxxxxxxxxxx> <9cde8bff05080301022cf0d33@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.4 (gnu/linux)
aq> as under "memory"node, there probably are several nodes besides
aq> "target" 

There probably /will/ be several nodes besides target, but there
aren't /yet/ :)

aq> (that means what triggered this watch may be not balloon
aq> request), i guess it is better to do some checking before calling
aq> set_new_target, like this:

If the desired behavior is really to only perform the watch duties
when a specific key is changed, I think it would be better to check
the node parameter of the watch handler.

Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@xxxxxxxxxx

Xen-devel mailing list