This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] A minor change to Makefile

To: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] A minor change to Makefile
From: Ulrich Drepper <drepper@xxxxxxxxxx>
Date: Sat, 16 Jul 2005 09:04:20 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sat, 16 Jul 2005 16:04:15 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <9DE394C12A921946AEECE1F71944ECD5023F8336@pdsmsx404>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Red Hat, Inc.
References: <9DE394C12A921946AEECE1F71944ECD5023F8336@pdsmsx404>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.2-7 (X11/20050623)
Jiang, Yunhong wrote:
> -       [ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen
> $(D)/etc/xen.old-$(date +%s)
> +       -[ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen
> $(D)/etc/xen.old-$(shell date +%s)

Not the right change.  Use

[ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen $(D)/etc/xen.old-$$(date +%s)

make needs the sub-shell command to be escaped (two $).

➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

Attachment: signature.asc
Description: OpenPGP digital signature

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>