This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Xen-changelog] This adds a patch for the vanilla kernel

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-changelog] This adds a patch for the vanilla kernel, to be pushed upstream some
From: Rik van Riel <riel@xxxxxxxxxx>
Date: Tue, 12 Jul 2005 11:47:20 -0400 (EDT)
Delivery-date: Tue, 12 Jul 2005 15:46:03 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E1Ds0Vu-0004aO-Bd@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1Ds0Vu-0004aO-Bd@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 11 Jul 2005, Xen patchbot -unstable wrote:

> --- a/linux-2.6-xen-sparse/arch/xen/i386/mm/pgtable.c Mon Jul 11 15:43:12 2005
> +++ b/linux-2.6-xen-sparse/arch/xen/i386/mm/pgtable.c Mon Jul 11 15:46:46 2005

>       if (PTRS_PER_PMD == 1 || !pgd)
>               return pgd;
> +     if (!HAVE_SHARED_KERNEL_PMD) {
> +             /* alloc and copy kernel pmd */
> +             unsigned long flags;
> +             pgd_t *copy_pgd = pgd_offset_k(PAGE_OFFSET);
> +             pud_t *copy_pud = pud_offset(copy_pgd, PAGE_OFFSET);

I don't understand how the code inside this if condition
ever gets to run.  Surely the previous test should catch
the non-PAE case already ?

Or is this code a preparation for non-3:1 splits ?

The Theory of Escalating Commitment: "The cost of continuing mistakes is
borne by others, while the cost of admitting mistakes is borne by yourself."
  -- Joseph Stiglitz, Nobel Laureate in Economics

Xen-devel mailing list