WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Add DOM0_GETDOMAININFOLIST op for bulkretrieval

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Add DOM0_GETDOMAININFOLIST op for bulkretrieval of domain info
From: Josh Triplett <josht@xxxxxxxxxx>
Date: Mon, 27 Jun 2005 11:33:59 -0700
Delivery-date: Mon, 27 Jun 2005 18:33:22 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <cf85f5daaabff3a470f03eb331533971@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <A95E2296287EAD4EB592B5DEEFCE0E9D28239A@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <cf85f5daaabff3a470f03eb331533971@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sat, 2005-06-25 at 10:17 +0100, Keir Fraser wrote:
> On 25 Jun 2005, at 02:41, Ian Pratt wrote:
> 
> >> Using a small test program, on a system with 97 domains with
> >> non-contiguous domain IDs, I found that with this hypercall I
> >> could retrieve the full array of info structures 12840 times
> >> per second, an improvement from 2380 times per second with
> >> the DOM0_GETDOMAININFO op.
> >
> > Can't you just reuse the existing xc_getdomain_info function and change
> > the hypercall depending on the number of domains being requested?
> 
> Why not just add nr_doms argument to existing GETDOMAININFO op?
> Maybe make nr_doms==0 same as nr_doms==1 for backward source 
> compatibility.

DOM0_GETDOMAININFO only includes one dom0_getdomaininfo_t structure, not
a pointer to an array of such structures (and the length of that array),
so the operation would have no place to store the data.

- Josh Triplett



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel