 Home |
Products |
Support |
Community |
News |
xen-devel
RE: [Xen-devel] [patch] fix serial locking
| To: | "Hollis Blanchard" <hollisb@xxxxxxxxxx>, "Xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | RE: [Xen-devel] [patch] fix serial locking |
| From: | "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx> |
| Date: | Wed, 15 Jun 2005 22:43:54 +0100 |
| Delivery-date: | Wed, 15 Jun 2005 21:42:59 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcVx7ZqxN68wKyWCSNuIBkQ26BQiWgABWtcA |
| Thread-topic: | [Xen-devel] [patch] fix serial locking |
> Hi Keir, I'm having trouble with the serial locking patch > from a couple weeks ago, specifically serial_getc(): > spin_lock_irqsave(&port->lock, flags); > ... > if ( port->driver->getc(port, &c) ) > break; > > spin_unlock_irqrestore(&port->lock, flags); > > That leaves port->lock locked, as soon as the first char is > successfully received. This patch fixes it for me: > Should I take this to mean that almost nobody uses serial console? Thanks for the patch. Most of us use serial console for debugging, but apparently only for output... Ian _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [Xen-devel] bitkeeper gone in 2 weeks - which RCS?, Ian Pratt |
|---|---|
| Next by Date: | Re: [Xen-devel] bitkeeper gone in 2 weeks - which RCS?, Andrew Thompson |
| Previous by Thread: | Re: [Xen-devel] [patch] fix serial locking, Keir Fraser |
| Next by Thread: | [Xen-devel] [PATCH] Patch for MMIO cleanup & 64bit instructions decoding, Kamble, Nitin A |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
