WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [netfilter-core] Re: [PATCH] Avoid unncessary checksum v

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [netfilter-core] Re: [PATCH] Avoid unncessary checksum validation in TCP/UDP netfilter
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sun, 12 Jun 2005 17:06:03 +0200
Cc: Phil Oester <kernel@xxxxxxxxxxxx>, cedric@xxxxxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Delivery-date: Mon, 13 Jun 2005 09:40:47 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <875052371a3a7c5217e413d7250320f9@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1DbccR-00063Q-00@xxxxxxxxxxxxxxxxx> <20050527112039.GA10084@xxxxxxxxxxxx> <875052371a3a7c5217e413d7250320f9@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.8) Gecko/20050514 Debian/1.7.8-1
Keir Fraser wrote:
> On 27 May 2005, at 12:20, Phil Oester wrote:
>> On Fri, May 27, 2005 at 12:03:08PM +0100, Keir Fraser wrote:
>>
>>> The TCP/UDP connection-tracking code in netfilter validates the
>>> checksum of incoming packets, to prevent nastier errors further down
>>> the road. This check is unnecessary if the skb is marked as
>>> CHECKSUM_UNNECESSARY.
>>
>> It seems at least part of this has already been merged in 2.6.12-rc
> 
> It would be great if the UDP code also would observe
> CHECKSUM_UNNECESSARY. I'll wait for 2.6.12 to appear and then submit a
> new patch if UDP has been missed.

TCP was changed to fix a regression with loopback packets. I've added
the UDP part of your patch to my 2.6.13 tree.

Regards
Patrick

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] Re: [netfilter-core] Re: [PATCH] Avoid unncessary checksum validation in TCP/UDP netfilter, Patrick McHardy <=