This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] Make strace happy with xeno64.

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Make strace happy with xeno64.
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Fri, 10 Jun 2005 16:37:13 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 10 Jun 2005 08:36:32 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcVtlzy2FOgfcpoVTVOatZ8owHv29AAAFStw
Thread-topic: [Xen-devel] [PATCH] Make strace happy with xeno64.
I will test it

Keir Fraser wrote:
> On 10 Jun 2005, at 09:06, Keir Fraser wrote:
>>> Hi Keir, do you have time to take a look at this patch?
>>> -Xin 
>>> Li, Xin B wrote:
>>>> On x86_64, strace expects CS == 0x33 for 64bit
>>>> applications and CS == 0x23 for 32bit applications, or
>>>> it will complain. This patch makes strace happy with
>>>> xeno64. 
>> The CS should be 0x23/0x33 -- no need for masking? Or is
>> the fact that the upcall saved mask appears in bits
>> 16-23 of the '4-byte' CS value a problem? We can move
>> the saved mask if so: I think that would be neater.
> I see that xenlinux places its own save mask at CS+4
> anyway (not CS+2 as Xen does). So I've moved the Xen mask
> to CS+4 too. A very simple patch and you probably now
> will not need to patch the strace path. 
>   -- Keir

Xen-devel mailing list