Re: [Xen-devel] [PATCH] xm --version

To:	Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] xm --version
From:	aq <aquynh@xxxxxxxxx>
Date:	Tue, 7 Jun 2005 20:00:11 +0900
Cc:	Xen Dev <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Thu, 09 Jun 2005 01:05:59 +0000
Domainkey-signature:	a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=pk+K80TeUBaPVEyF0izrmMOOWkpDidRV7WD0Kgm32Dd6tEie0P6EF/uMCfayxLJZ4QPkxEZ4/4XfXpd92oa5n9daPS6Etne2cJaiFyUQGfwNlgcwn0iMH/xk3Km1fUyb4FVSJP+nbhERRa0w47mXZRneNLKAn/+pRQuS2rBRStE=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<A95E2296287EAD4EB592B5DEEFCE0E9D2820D9@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<A95E2296287EAD4EB592B5DEEFCE0E9D2820D9@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	aq <aquynh@xxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 6/7/05, Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx> wrote:
> > Ian, i look at the xen source code, and looks like "noht"
> > option is never used anywhere? also ht_per_core is always set
> > to 1? does xen really support HyperThreading now ? (i doubt that)
> 
> Xen supports hyperthreading just fine, and even does initial domain
> placement using an algorithm that understands it.
> 
> In fact, it looks like we effectively lost the option to ever disable
> hyperthreading when the setup code got upgraded. 

can you confirm that ht_per_core is also wrongly set? it is set (=1)
at arch/x86/setup.c or arch/ia64/smpboot.c, but never changed. but
this variable is used somewhere, and got reported in "xm info", for
example.

so all of its usage are also wrong when we use HT? (because in that
case ht_per_core must be 2)

>It would be nice if
> part of your patch removed any reference to 'noht', including in the
> documentation.

fine, i will submit a patch on this problem.

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] xm --version