This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] FP fix for x86-64 xenlinux

On 6 Jun 2005, at 09:23, Nakajima, Jun wrote:

That's better. I'll send another patch. BTW, they are defined like the
below for x86 xenlinux:

#define read_cr0() \
#define write_cr0(x) \

We need to fix this as well.

Ah. I guess raid6 accesses %cr0 via its own assembly macros. But yes, I think defining the above, and read/write_cr4, the same as native is the right thing to do. We can then add in extra functionality to the emulation as required. I don't think this will mask bugs in the guest OS -- accesses to %cr4 currently aren;t emulated anyway so they will crash just as they do today. I may tighten up emulation of %cr0 a bit so toggling of unexpected bits at least causes a DPRINTK.

 -- Keir

Xen-devel mailing list