WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] missing put_domain in DOM0_IOPORT_PERMISSION

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] missing put_domain in DOM0_IOPORT_PERMISSION
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Fri, 3 Jun 2005 19:22:13 +0100
Delivery-date: Fri, 03 Jun 2005 18:21:25 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.3.25i
There appears to be a missing put_domain() in the failure case. The code
doesn't seem to be used by anyone, but anyway...

(I haven't tested this at all)

regards,
john

Signed-off-by: John Levon <levon@xxxxxxxxxxxxxxxxx>

--- xen/arch/x86/dom0_ops.c     2005-05-25 04:14:26.000000000 +0100
+++ xen/arch/x86/dom0_ops.new.c 2005-06-03 19:25:19.000000000 +0100
@@ -155,7 +155,10 @@ long arch_do_dom0_op(dom0_op_t *op, dom0
         {
             if ( (d->arch.iobmp_mask = xmalloc_array(
                 u8, IOBMP_BYTES)) == NULL )
+            {
+                put_domain(d);
                 break;
+            }
             memset(d->arch.iobmp_mask, 0xFF, IOBMP_BYTES);
         }
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] missing put_domain in DOM0_IOPORT_PERMISSION, John Levon <=