WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] make domu_debug run-time option + fix int3handli

To: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] make domu_debug run-time option + fix int3handling for MP
From: Christian Limpach <christian.limpach@xxxxxxxxx>
Date: Mon, 16 May 2005 23:31:17 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Kip Macy <kmacy@xxxxxxxxxx>
Delivery-date: Mon, 16 May 2005 22:30:48 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=tAxhvvHiKsSFiA3ztEE+vKqPFl4NB2R0Z6Jht9lMVoVFYSTWz48OD2e0yw/JMDhuaN9sOEv99/IuxBJBT545WdNDDEsuXuY4fegOimzpZKxc32wol9emjHEKWkFTWnNdeovtm52w/Y0EvNFZB0fQdCVtyztpA6O5kVYMlM5o7vg=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <A95E2296287EAD4EB592B5DEEFCE0E9D1E406A@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <A95E2296287EAD4EB592B5DEEFCE0E9D1E406A@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: Christian.Limpach@xxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 5/16/05, Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx> wrote:
> > On Mon, May 16, 2005 at 03:08:24PM -0700, Kip Macy wrote:
> > > "domu_debug" was mutually exclusive with crash_debug, which doesn't
> > > make sense to me. The other stub already had a #if 0 as a
> > > pre-processor guard around it. So the end effect with the patch is
> > > that domu_debug would be on by default and cdb could be enabled at
> > > compile-time. As I recall, there is no working
> > functionality that this changes.  I'll go back and look and
> > recant if I am in error.
> >
> > Unless I misread the patch (didn't apply it), you'd end up
> > with unconditional definitions of debugger_trap_fatal and
> > debugger_trap_immediate?
> > I usually just toggle the #elif 0 to enable the kdb stubs, I
> > don't see how that would work now, without having to do more changes?
> 
> Do we ever want to enter cdb or kdb for any domain other than dom0? I
> can't think why you'd want to, as there's a much nicer debug environment
> available for domU's.

debugger_trap_fatal and debugger_trap_immediate are only used in code
paths which cause a Xen reboot and the nicer debug environment will be
dead by then...

Good point though for making debugger_trap_entry domu_debug only,
might even be reasonable to rename it...

    christian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>