WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: Assertion failure on shadow.c:2339 for VMX domains

To: Michael A Fetterman <Michael.Fetterman@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: Assertion failure on shadow.c:2339 for VMX domains
From: Arun Sharma <arun.sharma@xxxxxxxxx>
Date: Fri, 13 May 2005 17:01:28 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sat, 14 May 2005 00:00:44 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <42852AF2.40409@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <42852AF2.40409@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.2-1.3.2 (X11/20050324)
Arun Sharma wrote:
Hi Michael,

This assertion you added:

005/05/09 mafetter | ASSERT(VM_ASSIST(d, VMASST_TYPE_writable_pagetables));

is failing for VMX domains. Why do you think this assertion belongs there?

Ditto for the other two below as well.

        -Arun

--- 1.111/xen/arch/x86/shadow.c 2005-05-12 06:58:45 -07:00
+++ edited/arch/x86/shadow.c    2005-05-13 15:49:11 -07:00
@@ -2336,8 +2336,6 @@
             l1_pgentry_t *shadow1 = shadow;
             l1_pgentry_t *snapshot1 = snapshot;

-            ASSERT(VM_ASSIST(d, VMASST_TYPE_writable_pagetables));
-
             if ( !shadow_mode_refcounts(d) )
                 revalidate_l1(d, guest1, snapshot1);

@@ -2383,7 +2381,6 @@
             l2_pgentry_t *shadow2 = shadow;
             l2_pgentry_t *snapshot2 = snapshot;

-            ASSERT(shadow_mode_write_all(d));
             BUG_ON(!shadow_mode_refcounts(d)); // not yet implemented

             changed = 0;
@@ -2426,7 +2423,6 @@
             l2_pgentry_t *snapshot2 = snapshot;
             l1_pgentry_t *shadow2 = shadow;

-            ASSERT(shadow_mode_write_all(d));
             BUG_ON(!shadow_mode_refcounts(d)); // not yet implemented

             changed = 0;




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>