WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [RESUBMIT] [PATCH] xen, tools: pincpu use vcpu and cpuma

To: Ryan Harper <ryanh@xxxxxxxxxx>
Subject: Re: [Xen-devel] [RESUBMIT] [PATCH] xen, tools: pincpu use vcpu and cpumap_t
From: Mike Wray <mike.wray@xxxxxx>
Date: Thu, 05 May 2005 16:49:50 +0100
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 05 May 2005 16:06:45 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050503235807.GB11696@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20050426223109.GC14932@xxxxxxxxxx> <4277AC20.7060804@xxxxxx> <20050503235807.GB11696@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.2 (X11/20050317)
Ryan Harper wrote:
* Mike Wray <mike.wray@xxxxxx> [2005-05-03 12:01]:

Ryan Harper wrote:

Here is an update to the previous pincpu patches.  This patch updates
the pincpu dom0op to use a cpumap_t pointer, rather than specifying a
size in the interface.  cpumap_t is current typedef'ed to an unsigned
long.  xm list -v now truncates the cpumap field to only show the bits
of the map that are relevant.  That is, if you have four VCPUS, you will
only see the first four bits of the cpumap.
This patch compiles against current unstable tree, but I could not test
it as the current unstable tree crashes dom0 when booting domU.  I back
ported the patch to 20050420 snapshot and it worked there.


This patch causes the dom0 crash I reported on the current unstable
(attached) so it needs fixing before applying.


I was not able to recreate dom0 crash with the previous patch against
current nightly snapshot (20050503).  None-the-less addressing some of
your feedback.
Attached is an updated patch.
 o bumped cpumap_t up to u64, per Ian and Keir
 o Fixed deref of user-space pointer without copy_from_user(), Mike Wray
 o Added put_domain() in ed > MAX_VIRT_CPUS error path, Mike Wray

OK, I'll give it another whirl.

Mike

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel