This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Guest boot loader support

To: Jeremy Katz <katzj@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Guest boot loader support
From: aq <aquynh@xxxxxxxxx>
Date: Tue, 26 Apr 2005 18:54:31 +0900
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 26 Apr 2005 09:54:13 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=eDhW81P6dcpQfYLtYHM9CGrAxy5J8wJCKu1zZw9TNDh3ITenekyFbABIkGHkgnx9ibpQ2jjkybQvmeCdT5g2MeuDlSWPBLHDLM5beVQ8eKxZDJf0g/INFyuNHmtHSgWbj44+9bWq7YDMIp9xpi4Zs/hgOadHHZWPSKIs8kOQs+Y=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <9cde8bff050426023247aa475b@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1114469427.4336.42.camel@xxxxxxxxxxxxxx> <9cde8bff050426023247aa475b@xxxxxxxxxxxxxx>
Reply-to: aq <aquynh@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 4/26/05, aq <aquynh@xxxxxxxxx> wrote:
> On 4/26/05, Jeremy Katz <katzj@xxxxxxxxxx> wrote:
> > Attached is an updated version of the patch to add boot loader support
> > for guest domains.
> >
> > Changes from the initial set of patches:
> > * Per Ian's request, adds an option to specify booting a specific kernel
> > from the host domain (you can specify it either with the title of the
> > boot loader config entry or with the grub 0-based index)
> > * Reduces some of the code duplication for finding out what the virtual
> > disk to boot off of is
> > * Improved error handling to use the standard Xen logging and error
> > facilities
> >

Jeremy, I looked at your code, and find few lines like this:

   exec("%s = r\"%s\"" %(self.commands[com], arg.strip()))

Looks like you dont need the above "r". Then the code should be:

   exec("%s = \"%s\"" %(self.commands[com], arg.strip()))

Here is a small patch (against your patch) to remove those typos.

$ diffstat booloader1.patch
 xen-bootloader2.patch |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Signed-off-by: Nguyen Anh Quynh <aquynh@xxxxxxxxx>

Attachment: booloader1.patch
Description: Binary data

Xen-devel mailing list