Re: [Xen-devel] [patch] pagetable cleanups

[Gerd Knorr <kraxel@xxxxxxxxxxx>]

> Personally think having "a = foo(b,c)" is actually more readable than
> "foo(&a,b,c)".

In that case yes.
If you use that to avoid extra temporary variables, i.e.

        bar(x, foo(b,c));

instead of

        a = foo(b,c);
        bar(x,a);

it quickly becomes unreadable, especially if the function and argument
names are a bit longer and the first version doesn't fit onto a single
line any more.  You are not forced to do that though, even if the
macros/functions _do_ return the entries ;)

I'll go over it again ...

  Gerd

-- 
#define printk(args...) fprintf(stderr, ## args)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel