[Xen-devel] potential bug in "xm atropos" implementation

[Diwaker Gupta <diwakergupta@xxxxxxxxx>]

>From tools/libxc/xc_atropos.c:

int xc_atropos_domain_set(int xc_handle,
                          u32 domid, u64 period, u64 slice, u64 latency,
                          int xtratime)

which takes 6 arguments

>From tools/python/xen/xm/main.py:
class ProgAtropos(Prog):
<snip>
    def main(self, args):
        if len(args) != 5: self.err("%s: Invalid argument(s)" % args[0])
        dom = args[1]
        v = map(int, args[2:5])
        server.xend_domain_cpu_atropos_set(dom, *v)

Now if you specify all 6 arguments on the command line, xm atropos
fails with "Invalid arguments" due to the above code. If you give 5
arguments, ProgAtropos fails since the corresponding libxc function
call takes 6 arguments.

Following patch will fix it:
Index: main.py
===================================================================
--- main.py     (revision 185)
+++ main.py     (working copy)
@@ -579,9 +579,9 @@
         print "\nSet atropos parameters."

     def main(self, args):
-        if len(args) != 5: self.err("%s: Invalid argument(s)" % args[0])
+        if len(args) != 6: self.err("%s: Invalid argument(s)" % args[0])
         dom = args[1]
-        v = map(int, args[2:5])
+        v = map(int, args[2:6])
         server.xend_domain_cpu_atropos_set(dom, *v)

 xm.prog(ProgAtropos)

-- 
Diwaker Gupta
http://resolute.ucsd.edu/diwaker


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel