This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] compile fixes for mini-os

To: Kip Macy <kmacy@xxxxxxxxxxx>
Subject: Re: [Xen-devel] compile fixes for mini-os
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sun, 25 Jan 2004 01:58:48 +0000
Cc: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 25 Jan 2004 01:59:45 +0000
Envelope-to: steven.hand@xxxxxxxxxxxx
In-reply-to: Your message of "Sat, 24 Jan 2004 17:27:10 PST." <20040124171555.S81692@xxxxxxxxxxxxxxxxxxxxx>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
> > Personally I dislike the warnings GCC emits when it's placed in
> > super-anal mode. I would never take fixes for Xen or Xenolinux to stop
> > those warnings since I think GCC should be run with a more permissive
> > set of options.
> I admit that many of the options are just plain annoying. However, in
> one instance you were casting away volatile, which could get you in
> trouble.

Hmmm... volatile generally gets sprinkled round like magic dust. I'm
not convinced it's usually needed.

> There are more mundane problems that could cause issues, such
> as signed/unsigned comparisons. I would argue that you might as well
> never use the const qualifier if you're just going to cast it away in
> most cases. In addition you frequently do pointer arithmetic with void
> pointers, you're just relying on the compiler to know that you really
> mean char pointer. The changes to inline usage are neccessary to get
> the code to compile at all with -ansi.

I'll give the fixes a look - probably when I get back to Cambridge in
teh middle of next week. I'll probably take them all for the mini-os -
I'll have a think about whether any of the warning options should be
added to Xen as well.

 -- Keir

The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
Xen-devel mailing list