[Xen-changelog] [xen-unstable] x86: drop unused parameter from msi_compose_msg() and setup_msi_irq()

[Xen patchbot-unstable <patchbot@xxxxxxx>]

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxxxx>
# Date 1314443707 -3600
# Node ID 4a59d5ff7b4df2b5801e09669c2539bd32979183
# Parent  e17f70940d1f57fe04dde3bf4e243f75c89f0d0e
x86: drop unused parameter from msi_compose_msg() and setup_msi_irq()

This particularly eliminates the bogus passing of NULL by hpet.c.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
---


diff -r e17f70940d1f -r 4a59d5ff7b4d xen/arch/x86/hpet.c
--- a/xen/arch/x86/hpet.c       Sat Aug 27 12:14:38 2011 +0100
+++ b/xen/arch/x86/hpet.c       Sat Aug 27 12:15:07 2011 +0100
@@ -342,7 +342,7 @@
 {
     struct msi_msg msg;
 
-    msi_compose_msg(NULL, irq, &msg);
+    msi_compose_msg(irq, &msg);
     hpet_msi_write(irq, &msg);
 }
 
diff -r e17f70940d1f -r 4a59d5ff7b4d xen/arch/x86/irq.c
--- a/xen/arch/x86/irq.c        Sat Aug 27 12:14:38 2011 +0100
+++ b/xen/arch/x86/irq.c        Sat Aug 27 12:15:07 2011 +0100
@@ -1670,7 +1670,7 @@
              && !desc->chip_data->used_vectors )
             desc->chip_data->used_vectors = &pdev->info.used_vectors;
         set_domain_irq_pirq(d, irq, info);
-        setup_msi_irq(pdev, msi_desc, irq);
+        setup_msi_irq(msi_desc, irq);
         spin_unlock_irqrestore(&desc->lock, flags);
     }
     else
diff -r e17f70940d1f -r 4a59d5ff7b4d xen/arch/x86/msi.c
--- a/xen/arch/x86/msi.c        Sat Aug 27 12:14:38 2011 +0100
+++ b/xen/arch/x86/msi.c        Sat Aug 27 12:15:07 2011 +0100
@@ -120,8 +120,7 @@
 /*
  * MSI message composition
  */
-void msi_compose_msg(struct pci_dev *pdev, int irq,
-                            struct msi_msg *msg)
+void msi_compose_msg(int irq, struct msi_msg *msg)
 {
     unsigned dest;
     cpumask_t domain;
@@ -414,11 +413,11 @@
     return entry;
 }
 
-int setup_msi_irq(struct pci_dev *dev, struct msi_desc *msidesc, int irq)
+int setup_msi_irq(struct msi_desc *msidesc, int irq)
 {
     struct msi_msg msg;
 
-    msi_compose_msg(dev, irq, &msg);
+    msi_compose_msg(irq, &msg);
     set_irq_msi(msidesc);
     write_msi_msg(irq_desc[irq].msi_desc, &msg);
 
diff -r e17f70940d1f -r 4a59d5ff7b4d xen/include/asm-x86/msi.h
--- a/xen/include/asm-x86/msi.h Sat Aug 27 12:14:38 2011 +0100
+++ b/xen/include/asm-x86/msi.h Sat Aug 27 12:15:07 2011 +0100
@@ -81,7 +81,7 @@
 extern int pci_enable_msi(struct msi_info *msi, struct msi_desc **desc);
 extern void pci_disable_msi(struct msi_desc *desc);
 extern void pci_cleanup_msi(struct pci_dev *pdev);
-extern int setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc, int irq);
+extern int setup_msi_irq(struct msi_desc *desc, int irq);
 extern void teardown_msi_irq(int irq);
 extern int msi_free_vector(struct msi_desc *entry);
 extern int pci_restore_msi_state(struct pci_dev *pdev);
@@ -221,6 +221,5 @@
        __u32   hi_address;
 } __attribute__ ((packed));
 
-void msi_compose_msg(struct pci_dev *pdev, int irq,
-                            struct msi_msg *msg);
+void msi_compose_msg(int irq, struct msi_msg *);
 #endif /* __ASM_MSI_H */

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog