xen-changelog

[Top] [All Lists]

[Xen-changelog] [xen-unstable] x86: Fix argument checking in (privileged

from [Xen patchbot-unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] [xen-unstable] x86: Fix argument checking in (privileged) function cpu_add().
From:	Xen patchbot-unstable <patchbot@xxxxxxx>
Date:	Thu, 16 Jun 2011 11:12:42 +0100
Delivery-date:	Thu, 16 Jun 2011 03:30:41 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User Keir Fraser <keir@xxxxxxx>
# Date 1307689724 -3600
# Node ID 5a557fda70a99d287735b53957e865c8dac0e351
# Parent  c34604d5a29336d902837542b915d3b09b27a361
x86: Fix argument checking in (privileged) function cpu_add().

Thanks to John McDermott <john.mcdermott@xxxxxxxxxxxx> for spotting.

Signed-off-by: Keir Fraser <keir@xxxxxxx>
---


diff -r c34604d5a293 -r 5a557fda70a9 xen/arch/x86/smpboot.c
--- a/xen/arch/x86/smpboot.c    Mon Jun 06 13:46:48 2011 +0100
+++ b/xen/arch/x86/smpboot.c    Fri Jun 10 08:08:44 2011 +0100
@@ -887,7 +887,9 @@
     dprintk(XENLOG_DEBUG, "cpu_add apic_id %x acpi_id %x pxm %x\n",
             apic_id, acpi_id, pxm);
 
-    if ( acpi_id > MAX_MADT_ENTRIES || apic_id > MAX_APICS || pxm > 256 )
+    if ( (acpi_id >= MAX_MADT_ENTRIES) ||
+         (apic_id >= MAX_APICS) ||
+         (pxm >= 256) )
         return -EINVAL;
 
     if ( !cpu_hotplug_begin() )

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] [xen-unstable] x86: Fix argument checking in (privileged) function cpu_add()., Xen patchbot-unstable <=

Previous by Date:	[Xen-changelog] [xen-unstable] nestedsvm: Support Decodeassist, Xen patchbot-unstable
Next by Date:	[Xen-changelog] [xen-unstable] x86/hvm: add SMEP support to HVM guest, Xen patchbot-unstable
Previous by Thread:	[Xen-changelog] [xen-unstable] nestedsvm: Support Decodeassist, Xen patchbot-unstable
Next by Thread:	[Xen-changelog] [xen-unstable] x86/hvm: add SMEP support to HVM guest, Xen patchbot-unstable
Indexes:	[Date] [Thread] [Top] [All Lists]