[Xen-changelog] [linux-2.6.18-xen] xenbus: simplify xenbus_dev_request_and_reply()

[Xen patchbot-linux-2.6.18-xen <patchbot@xxxxxxx>]

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxxxx>
# Date 1306941439 -3600
# Node ID 80fdb46627c0c319c65ab3edac2e6a4dc106e19c
# Parent  43583616b0d71dfccbd47f0f3ec062efd3c46658
xenbus: simplify xenbus_dev_request_and_reply()

No need to retain a local copy of the full request message, only the
type is really needed.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
---


diff -r 43583616b0d7 -r 80fdb46627c0 drivers/xen/xenbus/xenbus_xs.c
--- a/drivers/xen/xenbus/xenbus_xs.c    Wed Jun 01 16:16:45 2011 +0100
+++ b/drivers/xen/xenbus/xenbus_xs.c    Wed Jun 01 16:17:19 2011 +0100
@@ -203,10 +203,10 @@
 void *xenbus_dev_request_and_reply(struct xsd_sockmsg *msg)
 {
        void *ret;
-       struct xsd_sockmsg req_msg = *msg;
+       enum xsd_sockmsg_type type = msg->type;
        int err;
 
-       if (req_msg.type == XS_TRANSACTION_START)
+       if (type == XS_TRANSACTION_START)
                transaction_start();
 
        mutex_lock(&xs_state.request_mutex);
@@ -220,9 +220,8 @@
 
        mutex_unlock(&xs_state.request_mutex);
 
-       if ((req_msg.type == XS_TRANSACTION_END) ||
-           ((req_msg.type == XS_TRANSACTION_START) &&
-            (msg->type == XS_ERROR)))
+       if ((type == XS_TRANSACTION_END) ||
+           ((type == XS_TRANSACTION_START) && (msg->type == XS_ERROR)))
                transaction_end();
 
        return ret;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog