WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] Remove "uninitialized_var" macro, which d

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] Remove "uninitialized_var" macro, which doesn't work with clang.
From: Xen patchbot-unstable <patchbot@xxxxxxx>
Date: Wed, 13 Apr 2011 21:20:08 +0100
Delivery-date: Wed, 13 Apr 2011 13:20:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Tim Deegan <Tim.Deegan@xxxxxxxxxx>
# Date 1302682690 -3600
# Node ID ab15b6853300b1b489f47bb201d639a11f46878f
# Parent  56a3b9c7367f67b07fa5cb709c883fd61bb88fbd
Remove "uninitialized_var" macro, which doesn't work with clang.

Since its only user is in ACPI parsing code, the extra overhead of
initializing to 0 is not worth fighting over.

Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
---


diff -r 56a3b9c7367f -r ab15b6853300 xen/drivers/acpi/tables/tbutils.c
--- a/xen/drivers/acpi/tables/tbutils.c Tue Apr 12 14:55:25 2011 +0100
+++ b/xen/drivers/acpi/tables/tbutils.c Wed Apr 13 09:18:10 2011 +0100
@@ -369,7 +369,7 @@
        u32 table_count;
        struct acpi_table_header *table;
        acpi_physical_address address;
-       acpi_physical_address uninitialized_var(rsdt_address);
+       acpi_physical_address rsdt_address = 0;
        u32 length;
        u8 *table_entry;
        acpi_status status;
diff -r 56a3b9c7367f -r ab15b6853300 xen/include/xen/compiler.h
--- a/xen/include/xen/compiler.h        Tue Apr 12 14:55:25 2011 +0100
+++ b/xen/include/xen/compiler.h        Wed Apr 13 09:18:10 2011 +0100
@@ -66,10 +66,4 @@
     __asm__ ("" : "=r"(__ptr) : "0"(ptr));      \
     (typeof(ptr)) (__ptr + (off)); })
 
-/*
- * A trick to suppress uninitialized variable warning without generating any
- * code
- */
-#define uninitialized_var(x) x = x
-
 #endif /* __LINUX_COMPILER_H */

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] Remove "uninitialized_var" macro, which doesn't work with clang., Xen patchbot-unstable <=