[Xen-changelog] [xen-unstable] tools/xl: fix race which can leave an xl monitor processing hanging

[Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
# Date 1292521164 0
# Node ID 1800f15da48a81d63635ceb6ca77dacbf50dc303
# Parent  4b92c5ea284a26250c574235cc649ed3b2f6fbf6
tools/xl: fix race which can leave an xl monitor processing hanging

If the domain is destroyed (eg with xl destroy), it is possible that
the xl which is monitoring the domain for restart/preserve will not be
able to get the domain shutdown reason.

Before this patch, it would then ignore the domain death event and
carry on waiting, forever, for more events.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 tools/libxl/xl_cmdimpl.c |    3 +++
 1 files changed, 3 insertions(+)

diff -r 4b92c5ea284a -r 1800f15da48a tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Thu Dec 16 16:58:39 2010 +0000
+++ b/tools/libxl/xl_cmdimpl.c  Thu Dec 16 17:39:24 2010 +0000
@@ -1848,6 +1848,9 @@ start:
                         ret = 0;
                         goto out;
                     }
+                } else {
+                    LOG("Unable to get domain death info, quitting");
+                    goto out;
                 }
                 break;
             case LIBXL_EVENT_DISK_EJECT:

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog