WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] xend: fix "xm block-detach 0 ..." for ext

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] xend: fix "xm block-detach 0 ..." for extended-ID devices
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 23 Dec 2010 05:33:40 -0800
Delivery-date: Thu, 23 Dec 2010 05:36:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxxxx>
# Date 1292004499 0
# Node ID 56359dc2b207c3b80bc47851838dcde6d79d2b22
# Parent  3b3fce9050b9b14f3a11123f6943998413ea7e7e
xend: fix "xm block-detach 0 ..." for  extended-ID devices

Simply taking stat()'s st_rdev doesn't work here, as the minor is
split into two parts, the major is present, and the "extended" bit
isn't set.

Rather than fixing this in a way that would likely be OS-dependent,
simply remove the access to the device file, and instead just parse
the provided string (as is done e.g. for block-attach).

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 tools/python/xen/util/blkif.py |    5 -----
 1 files changed, 5 deletions(-)

diff -r 3b3fce9050b9 -r 56359dc2b207 tools/python/xen/util/blkif.py
--- a/tools/python/xen/util/blkif.py    Fri Dec 10 16:49:05 2010 +0000
+++ b/tools/python/xen/util/blkif.py    Fri Dec 10 18:08:19 2010 +0000
@@ -18,11 +18,6 @@ def blkdev_name_to_number(name):
 
     devname = 'virtual-device'
     devnum = None
-
-    try:
-        return (devname, os.stat(n).st_rdev)
-    except Exception, ex:
-        pass
 
     scsi_major = [ 8, 65, 66, 67, 68, 69, 70, 71, 128, 129, 130, 131, 132, 
133, 134, 135 ]
     if re.match( '/dev/sd[a-z]([1-9]|1[0-5])?$', n):

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] xend: fix "xm block-detach 0 ..." for extended-ID devices, Xen patchbot-unstable <=