WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-4.0-testing] Fix fd leak in xenstore

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-4.0-testing] Fix fd leak in xenstore
From: "Xen patchbot-4.0-testing" <patchbot-4.0-testing@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 20 Sep 2010 21:55:10 -0700
Delivery-date: Mon, 20 Sep 2010 21:55:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1284535198 -3600
# Node ID 86b99b9ad6ef9492b66c98e2377105f3ea584cbf
# Parent  89605b79f56529d34d963d0d91c67c46294a7b7c
Fix fd leak in xenstore

Missing from commit 'libxl: Backported stuff from unstable'
Without this change, xs_daemon_open/xs_daemon_close will leak
file descriptors.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
---
 tools/xenstore/xs.c |    2 ++
 1 files changed, 2 insertions(+)

diff -r 89605b79f565 -r 86b99b9ad6ef tools/xenstore/xs.c
--- a/tools/xenstore/xs.c       Mon Sep 13 17:51:50 2010 +0100
+++ b/tools/xenstore/xs.c       Wed Sep 15 08:19:58 2010 +0100
@@ -285,6 +285,8 @@ void xs_daemon_close(struct xs_handle *h
        mutex_unlock(&h->request_mutex);
        mutex_unlock(&h->reply_mutex);
        mutex_unlock(&h->watch_mutex);
+
+       close_fds_free(h);
 }
 
 static bool read_all(int fd, void *data, unsigned int len)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-4.0-testing] Fix fd leak in xenstore, Xen patchbot-4.0-testing <=