xen-changelog

[Top] [All Lists]

[Xen-changelog] [xen-unstable] x86 p2m: Fix comment regarding mfn_valid(

from [Xen patchbot-unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] [xen-unstable] x86 p2m: Fix comment regarding mfn_valid().
From:	Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date:	Fri, 03 Sep 2010 09:50:32 -0700
Delivery-date:	Fri, 03 Sep 2010 09:53:38 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1283332599 -3600
# Node ID 2c2b177f8b711092572f70c90ff067745074099a
# Parent  73b131807d87df9b6c3b657dfcf9bdbcc3a27b1b
x86 p2m: Fix comment regarding mfn_valid().

MMIO pages are not always above max_page (e.g., >=4GB system with MMIO
in the RAM hole below 4GB).

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 xen/arch/x86/mm/p2m.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 73b131807d87 -r 2c2b177f8b71 xen/arch/x86/mm/p2m.c
--- a/xen/arch/x86/mm/p2m.c     Wed Sep 01 09:48:52 2010 +0100
+++ b/xen/arch/x86/mm/p2m.c     Wed Sep 01 10:16:39 2010 +0100
@@ -2621,7 +2621,7 @@ clear_mmio_p2m_entry(struct p2m_domain *
 
     mfn = gfn_to_mfn(p2m, gfn, &t);
 
-    /* Do not use mfn_valid() here as MMIO pages are always above max_page */
+    /* Do not use mfn_valid() here as it will usually fail for MMIO pages. */
     if ( (INVALID_MFN == mfn_x(mfn)) || (t != p2m_mmio_direct) )
     {
         gdprintk(XENLOG_ERR,

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] [xen-unstable] x86 p2m: Fix comment regarding mfn_valid()., Xen patchbot-unstable <=

Previous by Date:	[Xen-changelog] [xen-unstable] Revert 5b03813d8d6e "Make uint64_aligned_t and GUEST_HANDLE_64 visible to guests.", Xen patchbot-unstable
Next by Date:	[Xen-changelog] [xen-unstable] x86 shadow: explicitly link the pages of multipage shadows, Xen patchbot-unstable
Previous by Thread:	[Xen-changelog] [xen-unstable] Revert 5b03813d8d6e "Make uint64_aligned_t and GUEST_HANDLE_64 visible to guests.", Xen patchbot-unstable
Next by Thread:	[Xen-changelog] [xen-unstable] x86 shadow: explicitly link the pages of multipage shadows, Xen patchbot-unstable
Indexes:	[Date] [Thread] [Top] [All Lists]