WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-4.0-testing] x86: Suppress warnings about spurious

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-4.0-testing] x86: Suppress warnings about spurious pagefaults
From: "Xen patchbot-4.0-testing" <patchbot-4.0-testing@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 04 Jun 2010 03:46:03 -0700
Delivery-date: Fri, 04 Jun 2010 03:51:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1275645001 -3600
# Node ID 96e0b0506051015770e946ad911a6d3ed12888ab
# Parent  d68b0e4c378bf45015405aa053e8b07e786c46f7
x86: Suppress warnings about spurious pagefaults

RHEL4 guests take a fair number of spurious pagefaults on Nehalem; no
need to report each one of them at XENLOG_WARNING.

Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
xen-unstable changeset:   21514:88932ba626fe
xen-unstable date:        Fri Jun 04 10:04:30 2010 +0100
---
 xen/arch/x86/traps.c |   18 +-----------------
 1 files changed, 1 insertion(+), 17 deletions(-)

diff -r d68b0e4c378b -r 96e0b0506051 xen/arch/x86/traps.c
--- a/xen/arch/x86/traps.c      Fri Jun 04 10:49:43 2010 +0100
+++ b/xen/arch/x86/traps.c      Fri Jun 04 10:50:01 2010 +0100
@@ -1169,10 +1169,7 @@ static int __spurious_page_fault(
          (l2e_get_flags(l2e) & disallowed_flags) )
         return 0;
     if ( l2e_get_flags(l2e) & _PAGE_PSE )
-    {
-        l1e = l1e_empty(); /* define before use in debug tracing */
-        goto spurious;
-    }
+        return 1;
 
     l1t = map_domain_page(mfn);
     l1e = l1e_read_atomic(&l1t[l1_table_offset(addr)]);
@@ -1182,19 +1179,6 @@ static int __spurious_page_fault(
          (l1e_get_flags(l1e) & disallowed_flags) )
         return 0;
 
- spurious:
-    dprintk(XENLOG_WARNING, "Spurious fault in domain %u:%u "
-            "at addr %lx, e/c %04x\n",
-            current->domain->domain_id, current->vcpu_id,
-            addr, error_code);
-#if CONFIG_PAGING_LEVELS >= 4
-    dprintk(XENLOG_WARNING, " l4e = %"PRIpte"\n", l4e_get_intpte(l4e));
-#endif
-#if CONFIG_PAGING_LEVELS >= 3
-    dprintk(XENLOG_WARNING, " l3e = %"PRIpte"\n", l3e_get_intpte(l3e));
-#endif
-    dprintk(XENLOG_WARNING, " l2e = %"PRIpte"\n", l2e_get_intpte(l2e));
-    dprintk(XENLOG_WARNING, " l1e = %"PRIpte"\n", l1e_get_intpte(l1e));
     return 1;
 }
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-4.0-testing] x86: Suppress warnings about spurious pagefaults, Xen patchbot-4.0-testing <=