WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [linux-2.6.18-xen] ixgbe: memset size in netif_napi_del(

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [linux-2.6.18-xen] ixgbe: memset size in netif_napi_del()
From: "Xen patchbot-linux-2.6.18-xen" <patchbot-linux-2.6.18-xen@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 19 Aug 2009 07:40:32 -0700
Delivery-date: Wed, 19 Aug 2009 07:40:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1250683240 -3600
# Node ID ccfe24b79bb4fddf8210026938e65ac5360294cd
# Parent  a65005adb3ed8a20de6293511cb4920a5e6bda1d
ixgbe: memset size in netif_napi_del()

By inspection the memset appears to be long as napi->poll_dev
is a struct net_device not a struct napi_struct.

Cc: Mitch Williams <mitch.a.williams@xxxxxxxxx>
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
---
 drivers/net/ixgbe/kcompat.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r a65005adb3ed -r ccfe24b79bb4 drivers/net/ixgbe/kcompat.h
--- a/drivers/net/ixgbe/kcompat.h       Sun Aug 16 08:42:29 2009 +0100
+++ b/drivers/net/ixgbe/kcompat.h       Wed Aug 19 13:00:40 2009 +0100
@@ -1595,7 +1595,7 @@ extern int __kc_adapter_clean(struct net
        do { \
                WARN_ON(!test_bit(__LINK_STATE_RX_SCHED, 
&(_napi)->poll_dev.state)); \
                dev_put(&(_napi)->poll_dev); \
-               memset(&(_napi)->poll_dev, 0, sizeof(struct napi_struct));\
+               memset(&(_napi)->poll_dev, 0, sizeof((_napi)->poll_dev));\
        } while (0)
 #else /* DRIVER_IGB || DRIVER_IXGBE */
 #define netif_rx_complete(netdev, napi) netif_rx_complete(netdev)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [linux-2.6.18-xen] ixgbe: memset size in netif_napi_del(), Xen patchbot-linux-2.6.18-xen <=