[Xen-changelog] [xen-3.4-testing] Serialize iptables calls in hotplug scripts

["Xen patchbot-3.4-testing" <patchbot-3.4-testing@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1243863819 -3600
# Node ID 4bf42e91bd66723cf6cedfc03982e18dac455b7a
# Parent  28007c168f077aef994a541b08aedf2fad0368d4
Serialize iptables calls in hotplug scripts

iptables cannot correctly handle situations when more than one command
is trying to set netfilter rules. In such situations, iptables may
fail
with EAGAIN, which results in iptables: Unknown error
18446744073709551615.

Such situation can easily happen when multiple network devices are
configured for a domain as vif hotplug scripts are called in parallel
for all of the network devices.

Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
xen-unstable changeset:   19672:fe84a14aacd1
xen-unstable date:        Thu May 28 11:07:19 2009 +0100
---
 tools/hotplug/Linux/vif-common.sh |    4 ++++
 1 files changed, 4 insertions(+)

diff -r 28007c168f07 -r 4bf42e91bd66 tools/hotplug/Linux/vif-common.sh
--- a/tools/hotplug/Linux/vif-common.sh Mon Jun 01 14:43:07 2009 +0100
+++ b/tools/hotplug/Linux/vif-common.sh Mon Jun 01 14:43:39 2009 +0100
@@ -103,6 +103,8 @@ handle_iptable()
     return
   fi
 
+  claim_lock "iptables"
+
   if [ "$ip" != "" ]
   then
       local addr
@@ -117,6 +119,8 @@ handle_iptable()
       # No IP addresses have been specified, so allow anything.
       frob_iptable
   fi
+
+  release_lock "iptables"
 }
 
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog