WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [linux-2.6.18-xen] revert: "netfront/back: do not mark p

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [linux-2.6.18-xen] revert: "netfront/back: do not mark packets of length < MSS as GSO"
From: "Xen patchbot-linux-2.6.18-xen" <patchbot-linux-2.6.18-xen@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 16 Jan 2009 02:51:06 -0800
Delivery-date: Fri, 16 Jan 2009 02:55:13 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1231941822 0
# Node ID 8081d19dce896687c152a7bacccf2d41c0e4d153
# Parent  93ea699242418730253e2ae22c74bddd3e5fdfc9
revert: "netfront/back: do not mark packets of length < MSS as GSO"

  changeset:   774:107e10e0e07c
  user:        Keir Fraser <keir.fraser@xxxxxxxxxx>
  date:        Tue Jan 13 15:17:54 2009 +0000
  summary:     netfront/back: do not mark packets of length < MSS as GSO

Herbert Xu suggested a better fix in the network
stack which will follow.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 drivers/xen/netback/netback.c   |    5 -----
 drivers/xen/netfront/netfront.c |    8 --------
 2 files changed, 13 deletions(-)

diff -r 93ea69924241 -r 8081d19dce89 drivers/xen/netback/netback.c
--- a/drivers/xen/netback/netback.c     Wed Jan 14 11:44:54 2009 +0000
+++ b/drivers/xen/netback/netback.c     Wed Jan 14 14:03:42 2009 +0000
@@ -1345,11 +1345,6 @@ static void net_tx_action(unsigned long 
                        skb_shinfo(skb)->frags[0].page = (void *)~0UL;
                }
 
-               if (skb->data_len < skb_shinfo(skb)->gso_size) {
-                       skb_shinfo(skb)->gso_size = 0;
-                       skb_shinfo(skb)->gso_type = 0;
-               }
-
                __skb_queue_tail(&tx_queue, skb);
 
                pending_cons++;
diff -r 93ea69924241 -r 8081d19dce89 drivers/xen/netfront/netfront.c
--- a/drivers/xen/netfront/netfront.c   Wed Jan 14 11:44:54 2009 +0000
+++ b/drivers/xen/netfront/netfront.c   Wed Jan 14 14:03:42 2009 +0000
@@ -1439,14 +1439,6 @@ err:
                np->stats.rx_packets++;
                np->stats.rx_bytes += skb->len;
 
-#if HAVE_TSO
-               if (skb->data_len < skb_shinfo(skb)->gso_size) {
-                       skb_shinfo(skb)->gso_size = 0;
-#if HAVE_GSO
-                       skb_shinfo(skb)->gso_type = 0;
-#endif
-               }
-#endif
                __skb_queue_tail(&rxq, skb);
 
                np->rx.rsp_cons = ++i;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [linux-2.6.18-xen] revert: "netfront/back: do not mark packets of length < MSS as GSO", Xen patchbot-linux-2.6.18-xen <=