WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [linux-2.6.18-xen] linux, S3: dom0 doesn't need save ioa

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [linux-2.6.18-xen] linux, S3: dom0 doesn't need save ioapic state
From: "Xen patchbot-linux-2.6.18-xen" <patchbot-linux-2.6.18-xen@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 19 Nov 2008 08:10:48 -0800
Delivery-date: Wed, 19 Nov 2008 08:13:48 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1227024244 0
# Node ID 69694615aebb8663d2e92125193aca7cb5b89f6b
# Parent  d31b6ccf10e41bfc3c1af4b0ff75deb8e2d5b9d8
linux, S3: dom0 doesn't need save ioapic state

Dom0 doesn't need to save/restore ioapic state across S3
suspend/resume, as Xen already does it. The more important
is to avoid warnings on some platforms which may have
uninitialized RTEs to be weird value (like smi mode) but
masked. When dom0 saves those entries and then write back
later, it's easy to trigger Xen's sanity check from
ioapic_guest_write.

Signed-off-by: Kevin Tian <kevin.tian@xxxxxxxxx>
---
 arch/i386/kernel/io_apic-xen.c   |    2 ++
 arch/x86_64/kernel/io_apic-xen.c |    2 ++
 2 files changed, 4 insertions(+)

diff -r d31b6ccf10e4 -r 69694615aebb arch/i386/kernel/io_apic-xen.c
--- a/arch/i386/kernel/io_apic-xen.c    Fri Nov 07 17:04:20 2008 +0000
+++ b/arch/i386/kernel/io_apic-xen.c    Tue Nov 18 16:04:04 2008 +0000
@@ -2570,8 +2570,10 @@ static int ioapic_resume(struct sys_devi
 
 static struct sysdev_class ioapic_sysdev_class = {
        set_kset_name("ioapic"),
+#ifndef CONFIG_XEN
        .suspend = ioapic_suspend,
        .resume = ioapic_resume,
+#endif
 };
 
 static int __init ioapic_init_sysfs(void)
diff -r d31b6ccf10e4 -r 69694615aebb arch/x86_64/kernel/io_apic-xen.c
--- a/arch/x86_64/kernel/io_apic-xen.c  Fri Nov 07 17:04:20 2008 +0000
+++ b/arch/x86_64/kernel/io_apic-xen.c  Tue Nov 18 16:04:04 2008 +0000
@@ -2107,8 +2107,10 @@ static int ioapic_resume(struct sys_devi
 
 static struct sysdev_class ioapic_sysdev_class = {
        set_kset_name("ioapic"),
+#ifndef CONFIG_XEN
        .suspend = ioapic_suspend,
        .resume = ioapic_resume,
+#endif
 };
 
 static int __init ioapic_init_sysfs(void)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [linux-2.6.18-xen] linux, S3: dom0 doesn't need save ioapic state, Xen patchbot-linux-2.6.18-xen <=