[Xen-changelog] [xen-3.2-testing] xm: When dumping core of an errant domain do not unpause after the

["Xen patchbot-3.2-testing" <patchbot-3.2-testing@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1207577587 -3600
# Node ID e6db1dd73d78d18b9d139936854f8ca0e67793c0
# Parent  387b5107113771d863593aeb8414d51d542fcdab
xm: When dumping core of an errant domain do not unpause after the
dump. This could allow the domain to e.g., access disks after
fail-over.

Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
xen-unstable changeset:   17382:0834234fd668cb8004abd6cb2c7cf8a6c3211a64
xen-unstable date:        Fri Apr 04 10:18:45 2008 +0100
---
 tools/python/xen/xm/main.py |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff -r 387b51071137 -r e6db1dd73d78 tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py       Mon Apr 07 15:12:20 2008 +0100
+++ b/tools/python/xen/xm/main.py       Mon Apr 07 15:13:07 2008 +0100
@@ -1285,13 +1285,13 @@ def xm_dump_core(args):
     try:
         print "Dumping core of domain: %s ..." % str(dom)
         server.xend.domain.dump(dom, filename, live, crash)
+
+        if crash:
+            print "Destroying domain: %s ..." % str(dom)
+            server.xend.domain.destroy(dom)
     finally:
-        if not live and ds == DOM_STATE_RUNNING:
+        if not live and not crash and ds == DOM_STATE_RUNNING:
             server.xend.domain.unpause(dom)
-
-    if crash:
-        print "Destroying domain: %s ..." % str(dom)
-        server.xend.domain.destroy(dom)
 
 def xm_rename(args):
     arg_check(args, "rename", 2)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog