# HG changeset patch
# User Ewan Mellor <ewan@xxxxxxxxxxxxx>
# Date 1173403543 0
# Node ID 2e160a17ceb6a4196e1e0294136cd94304c8055a
# Parent be686775bdb0c1c480915cbe11fa2e6092a40ef4
Remove VDI.set_SR -- this was always unimplemented, and pretty mad.
Signed-off-by: Ewan Mellor <ewan@xxxxxxxxxxxxx>
---
docs/xen-api/xenapi-datamodel.tex | 36 +-----------------------------------
tools/libxen/include/xen_vdi.h | 7 -------
tools/libxen/src/xen_vdi.c | 16 ----------------
tools/python/xen/xend/XendAPI.py | 7 ++-----
4 files changed, 3 insertions(+), 63 deletions(-)
diff -r be686775bdb0 -r 2e160a17ceb6 docs/xen-api/xenapi-datamodel.tex
--- a/docs/xen-api/xenapi-datamodel.tex Fri Mar 09 01:15:07 2007 +0000
+++ b/docs/xen-api/xenapi-datamodel.tex Fri Mar 09 01:25:43 2007 +0000
@@ -9583,7 +9583,7 @@ Quals & Field & Type & Description \\
$\mathit{RO}_\mathit{run}$ & {\tt uuid} & string & unique identifier/object
reference \\
$\mathit{RW}$ & {\tt name/label} & string & a human-readable name \\
$\mathit{RW}$ & {\tt name/description} & string & a notes field containg
human-readable description \\
-$\mathit{RW}$ & {\tt SR} & SR ref & storage repository in which the VDI
resides \\
+$\mathit{RO}_\mathit{ins}$ & {\tt SR} & SR ref & storage repository in which
the VDI resides \\
$\mathit{RO}_\mathit{run}$ & {\tt VBDs} & (VBD ref) Set & list of vbds that
refer to this disk \\
$\mathit{RO}_\mathit{run}$ & {\tt crash\_dumps} & (crashdump ref) Set & list
of crash dumps that refer to this disk \\
$\mathit{RW}$ & {\tt virtual\_size} & int & size of disk as presented to the
guest (in bytes). Note that, depending on storage backend type, requested size
may not be respected exactly \\
@@ -9876,40 +9876,6 @@ SR ref
value of the field
-\vspace{0.3cm}
-\vspace{0.3cm}
-\vspace{0.3cm}
-\subsubsection{RPC name:~set\_SR}
-
-{\bf Overview:}
-Set the SR field of the given VDI.
-
- \noindent {\bf Signature:}
-\begin{verbatim} void set_SR (session_id s, VDI ref self, SR ref
value)\end{verbatim}
-
-
-\noindent{\bf Arguments:}
-
-
-\vspace{0.3cm}
-\begin{tabular}{|c|c|p{7cm}|}
- \hline
-{\bf type} & {\bf name} & {\bf description} \\ \hline
-{\tt VDI ref } & self & reference to the object \\ \hline
-
-{\tt SR ref } & value & New value to set \\ \hline
-
-\end{tabular}
-
-\vspace{0.3cm}
-
- \noindent {\bf Return Type:}
-{\tt
-void
-}
-
-
-
\vspace{0.3cm}
\vspace{0.3cm}
\vspace{0.3cm}
diff -r be686775bdb0 -r 2e160a17ceb6 tools/libxen/include/xen_vdi.h
--- a/tools/libxen/include/xen_vdi.h Fri Mar 09 01:15:07 2007 +0000
+++ b/tools/libxen/include/xen_vdi.h Fri Mar 09 01:25:43 2007 +0000
@@ -293,13 +293,6 @@ xen_vdi_set_name_description(xen_session
/**
- * Set the SR field of the given VDI.
- */
-extern bool
-xen_vdi_set_sr(xen_session *session, xen_vdi vdi, xen_sr sr);
-
-
-/**
* Set the virtual_size field of the given VDI.
*/
extern bool
diff -r be686775bdb0 -r 2e160a17ceb6 tools/libxen/src/xen_vdi.c
--- a/tools/libxen/src/xen_vdi.c Fri Mar 09 01:15:07 2007 +0000
+++ b/tools/libxen/src/xen_vdi.c Fri Mar 09 01:25:43 2007 +0000
@@ -410,22 +410,6 @@ xen_vdi_set_name_description(xen_session
bool
-xen_vdi_set_sr(xen_session *session, xen_vdi vdi, xen_sr sr)
-{
- abstract_value param_values[] =
- {
- { .type = &abstract_type_string,
- .u.string_val = vdi },
- { .type = &abstract_type_string,
- .u.string_val = sr }
- };
-
- xen_call_(session, "VDI.set_SR", param_values, 2, NULL, NULL);
- return session->ok;
-}
-
-
-bool
xen_vdi_set_virtual_size(xen_session *session, xen_vdi vdi, int64_t
virtual_size)
{
abstract_value param_values[] =
diff -r be686775bdb0 -r 2e160a17ceb6 tools/python/xen/xend/XendAPI.py
--- a/tools/python/xen/xend/XendAPI.py Fri Mar 09 01:15:07 2007 +0000
+++ b/tools/python/xen/xend/XendAPI.py Fri Mar 09 01:25:43 2007 +0000
@@ -1754,13 +1754,13 @@ class XendAPI(object):
# Xen API: Class VDI
# ----------------------------------------------------------------
- VDI_attr_ro = ['VBDs',
+ VDI_attr_ro = ['SR',
+ 'VBDs',
'physical_utilisation',
'sector_size',
'type']
VDI_attr_rw = ['name_label',
'name_description',
- 'SR',
'virtual_size',
'sharable',
'read_only']
@@ -1811,9 +1811,6 @@ class XendAPI(object):
def VDI_set_name_description(self, session, vdi_ref, value):
self._get_VDI(vdi_ref).name_description = value
return xen_api_success_void()
-
- def VDI_set_SR(self, session, vdi_ref, value):
- return xen_api_error(XEND_ERROR_UNSUPPORTED)
def VDI_set_virtual_size(self, session, vdi_ref, value):
return xen_api_error(XEND_ERROR_UNSUPPORTED)
_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog
|
Home